fix(wasix): Remove redundant module hash generation in BinaryPackage #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maminrayej
approved these changes
May 29, 2024
syrusakbary
reviewed
May 29, 2024
theduke
force-pushed
the
binpkg-hash-speedup
branch
from
1c030f1 to
013c2ee
Compare
The hash is already available, no need to re-compute.
Redundant method
theduke
force-pushed
the
binpkg-hash-speedup
branch
from
013c2ee to
2723a45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash is already available, no need to re-compute.
Closes #4785